Repository navigation
A cloud workspace can read its environment's variable names, and a deploy CLI's token can be one - #7874
Conversation
…ploy CLI's token can be one An agent in a box could not tell which variables its environment gives it: every environment.secrets procedure sat outside the box credential's allowlist, the CLI hid the whole secrets group in a box, and the next bundle would have hidden `environments` itself, since nothing in a box sets the internal audience. - environment.secrets.list joins SANDBOX_ALLOWED_PROCEDURES; set and remove stay a person's call. - In a box the CLI shows `environments secrets list`; set and delete carry sandbox: false themselves. A box runs with the internal audience. - The reserved prefix narrows from VERCEL_ to VERCEL_SANDBOX_, the only family the provisioner uses, so VERCEL_TOKEN and VERCEL_ORG_ID can be environment variables for the vercel CLI.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe CLI audience condition now recognizes a sandbox workspace ID. Environment secret commands and sandbox procedure access were updated. Reserved environment-key matching now targets the ChangesSandbox environment secrets
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to No concrete merge-blocking defect was established. The newly available secret-list operation still warrants validation in a deployed sandbox. Security Architecture ReviewSecurity architecture risk: 🟡 Moderate · up to Workspace access expands beyond secret-name listing because the CLI also makes other internal commands available. Secret values and secret-changing commands retain separate restrictions, but the effective limits on newly reachable plugin tools are not established here. Retained concerns
Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No installed development build can load this pull request as an update: its native fingerprint is |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30 Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)". Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23 were covered by #7771. Changes - Pages: no auto-open on publish (#7790); page links and URL links split into their own settings (#7916, #7962, #7946); Listening agents menu with per-row stop and Add listening agent (#7724, #7820, #7919); globe on the Share button (#7766); Report on public pages (#7886); agents offer a page (#7759). Files: pages.mdx, cli/cli-reference.mdx. - Settings moves: Links replaced by Browser and Files & Editor (#7916, #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx. - Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916), open and save files outside the workspace (#7897, #7982), Copy as Markdown (#7591), per-pane error screen (#7983). File: editor.mdx. - Terminal copy follows Ghostty's whitespace rules (#7868). File: terminal-integration.mdx. - Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx, cli/cli-reference.mdx. - Host: superset start --daemon --auto-update and update-lock permission errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx. - Removed the mcp CLI section and the Connected Service Plugins section: #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx, cli/cli-reference.mdx. - Slack page unfurls and details panel (#7817, #7821, #7914, #7957). File: use-with-slack.mdx. - Workspaces: instant creation with background naming (#7518); recoverable project deletion (#7896). File: workspaces.mdx. - Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx. - Ship controls and open-in button moved to the right sidebar strip (#7958). Files: diff-viewer.mdx, use-with-ide.mdx. Deliberately skipped - Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule): #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863 #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981 #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR). - Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955. - Already documented in their own PRs: #7917, #7921. - Removed feature never documented: #7796 Google Calendar triggers. - Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872. - Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792, #7798, #7761, #7948, #7949, #7951, #7827. - Reverted security trio: #7828 #7829 #7830 (reverted by #7834). - Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756 #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860 #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome. - Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810 #7814 #7816 #7889 #7968. - Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774 #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895 #7909 #7933 #7934 #7942 #7944 #7965 #7966. Validation: bun run --cwd apps/docs typecheck, bun run lint:fix, bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings), git diff --check. * chore: log weekly docs update follow-ups * docs: tighten review findings in the weekly update Only the page creator can stop or add listening agents. On focus change also saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do not unfurl. Model picker coverage matches agent-models.ts.
An agent in a cloud workspace couldn't see which variables its environment gives it, and
VERCEL_TOKEN/VERCEL_ORG_IDcouldn't be environment variables at all. Both block usingvercel,wranglerandeasfrom a box (binaries land in #7863).Changes
environment.secrets.listjoinsSANDBOX_ALLOWED_PROCEDURES. It returns names, visibility and timestamps, never values.setandremovestay a person's call.environments secrets listis visible;setanddeletecarrysandbox: falsethemselves instead of the whole group. A box runs with the internal audience, soenvironmentsdoesn't vanish there with the next bundle.VERCEL_toVERCEL_SANDBOX_, the only Vercel family the provisioner reads. New test pins it.Verification
bun testfor shared (new) and cli-framework pass; typecheck passes for cli, trpc and shared; biome clean.SUPERSET_SANDBOX_WORKSPACE_IDset,environments secretslists onlylist, andsetis an unknown command. Outside a box without the internal audience,environmentsstays hidden.After merge
Set
VERCEL_ORG_IDand a fresh scopedVERCEL_TOKENon the internal Superset environment (prod rejectsVERCEL_names until this deploys).EXPO_TOKENis already set; Cloudflare and Neon were already there.Summary by cubic
Lets a cloud workspace see which variables its environment provides, and lets deploy CLI credentials like
VERCEL_TOKENandVERCEL_ORG_IDlive as environment variables sovercel,wrangler, andeaswork from a box.environment.secrets.listjoins the sandbox allowlist and returns names, visibility, and timestamps, never values.environments secrets listin a box;setanddeleteare markedsandbox: falseindividually, and a box runs with the internal audience soenvironmentsstays visible.VERCEL_toVERCEL_SANDBOX_, the only Vercel family the provisioner reads.Migration
After deploy, set
VERCEL_ORG_IDand a fresh scopedVERCEL_TOKENon the internal Superset environment (prod currently rejectsVERCEL_names).Written for commit 404ac53. Summary will update on new commits.
Summary by CodeRabbit
New Features
VERCEL_can now be used, except those beginning withVERCEL_SANDBOX_.Bug Fixes