Skip to content

A cloud workspace can read its environment's variable names, and a deploy CLI's token can be one - #7874

Merged
saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/sandbox-agent-cli-env
Sep 27, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/sandbox-agent-cli-env

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

An agent in a cloud workspace couldn't see which variables its environment gives it, and VERCEL_TOKEN / VERCEL_ORG_ID couldn't be environment variables at all. Both block using vercel, wrangler and eas from a box (binaries land in #7863).

Changes

  • environment.secrets.list joins SANDBOX_ALLOWED_PROCEDURES. It returns names, visibility and timestamps, never values. set and remove stay a person's call.
  • CLI: in a box, environments secrets list is visible; set and delete carry sandbox: false themselves instead of the whole group. A box runs with the internal audience, so environments doesn't vanish there with the next bundle.
  • The reserved secret prefix narrows from VERCEL_ to VERCEL_SANDBOX_, the only Vercel family the provisioner reads. New test pins it.

Verification

  • bun test for shared (new) and cli-framework pass; typecheck passes for cli, trpc and shared; biome clean.
  • Built CLI: with SUPERSET_SANDBOX_WORKSPACE_ID set, environments secrets lists only list, and set is an unknown command. Outside a box without the internal audience, environments stays hidden.
  • Not verified end to end in a box: that needs this deployed plus a bundle with the new CLI.

After merge

Set VERCEL_ORG_ID and a fresh scoped VERCEL_TOKEN on the internal Superset environment (prod rejects VERCEL_ names until this deploys). EXPO_TOKEN is already set; Cloudflare and Neon were already there.


Summary by cubic

Lets a cloud workspace see which variables its environment provides, and lets deploy CLI credentials like VERCEL_TOKEN and VERCEL_ORG_ID live as environment variables so vercel, wrangler, and eas work from a box.

  • environment.secrets.list joins the sandbox allowlist and returns names, visibility, and timestamps, never values.
  • The CLI shows environments secrets list in a box; set and delete are marked sandbox: false individually, and a box runs with the internal audience so environments stays visible.
  • The reserved secret prefix narrows from VERCEL_ to VERCEL_SANDBOX_, the only Vercel family the provisioner reads.

Migration

After deploy, set VERCEL_ORG_ID and a fresh scoped VERCEL_TOKEN on the internal Superset environment (prod currently rejects VERCEL_ names).

Written for commit 404ac53. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • New Features

    • CLI access now supports both internal and public audiences when running in a sandbox workspace.
    • Sandbox credentials can access the environment secrets list.
    • Environment variable names beginning with VERCEL_ can now be used, except those beginning with VERCEL_SANDBOX_.
  • Bug Fixes

    • Environment secret set and delete commands now work correctly in sandbox contexts.

…ploy CLI's token can be one

An agent in a box could not tell which variables its environment gives it:
every environment.secrets procedure sat outside the box credential's
allowlist, the CLI hid the whole secrets group in a box, and the next
bundle would have hidden `environments` itself, since nothing in a box
sets the internal audience.

- environment.secrets.list joins SANDBOX_ALLOWED_PROCEDURES; set and
  remove stay a person's call.
- In a box the CLI shows `environments secrets list`; set and delete
  carry sandbox: false themselves. A box runs with the internal audience.
- The reserved prefix narrows from VERCEL_ to VERCEL_SANDBOX_, the only
  family the provisioner uses, so VERCEL_TOKEN and VERCEL_ORG_ID can be
  environment variables for the vercel CLI.
@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 27e6ab97-67f6-4eaf-9926-6ee93027c7c5

📥 Commits

Reviewing files that changed from the base of the PR and between 108560a and 404ac53.

📒 Files selected for processing (7)
  • packages/cli/cli.config.ts
  • packages/cli/src/commands/environments/secrets/delete/command.ts
  • packages/cli/src/commands/environments/secrets/meta.ts
  • packages/cli/src/commands/environments/secrets/set/command.ts
  • packages/shared/src/environment-secrets.test.ts
  • packages/shared/src/environment-secrets.ts
  • packages/trpc/src/lib/sandbox/api-credential.ts
💤 Files with no reviewable changes (1)
  • packages/cli/src/commands/environments/secrets/meta.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The CLI audience condition now recognizes a sandbox workspace ID. Environment secret commands and sandbox procedure access were updated. Reserved environment-key matching now targets the VERCEL_SANDBOX_ prefix, with tests for reserved-key results.

Changes

Sandbox environment secrets

Layer / File(s) Summary
Sandbox secret access configuration
packages/cli/cli.config.ts, packages/cli/src/commands/environments/secrets/delete/command.ts, packages/cli/src/commands/environments/secrets/set/command.ts, packages/cli/src/commands/environments/secrets/meta.ts, packages/trpc/src/lib/sandbox/api-credential.ts
The CLI enables both audiences when SUPERSET_SANDBOX_WORKSPACE_ID is set. The set and delete commands set sandbox to false, the metadata object no longer declares it, and the sandbox allowlist includes environment.secrets.list.
Reserved environment-key rules
packages/shared/src/environment-secrets.ts, packages/shared/src/environment-secrets.test.ts
The reserved prefix changes from VERCEL_ to VERCEL_SANDBOX_. Tests specify the expected reserved-key results for provider keys and deploy CLI credentials.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 404ac

No concrete merge-blocking defect was established. The newly available secret-list operation still warrants validation in a deployed sandbox.

Security Architecture Review

Security architecture risk: 🟡 Moderate · up to 404ac

Workspace access expands beyond secret-name listing because the CLI also makes other internal commands available. Secret values and secret-changing commands retain separate restrictions, but the effective limits on newly reachable plugin tools are not established here.

Retained concerns

  • Medium · security · inferred: A workspace now passes the CLI's internal-audience filter, making internal commands beyond environment-secret listing visible. The internal MCP call-tool command has no CLI sandbox exclusion; whether a sandbox request can execute a connected tool remains dependent on downstream authentication and authorization.
  • Low · security · inferred: The new sandbox permission can list secret names for environments visible through the workspace creator's organization-level identity, rather than enforcing a match to the originating workspace's environment. This broadens metadata visibility if those scopes are intended to differ; it does not expose secret values.
Security review details

Security Blast Radius

  • inferred — A caller controlling commands within a cloud workspace gains visibility of internal CLI command paths. Potential plugin-tool effects depend on successful downstream authentication, the resolved user's installed plugins and connections, and tool authorization; the inspected source does not establish unrestricted access.

Security Findings and Attack Paths

  • observed — The retained authorization finding concerns the new internal CLI audience in a workspace. Internal MCP commands are no longer excluded by audience filtering and are not marked sandbox:false; a tool invocation still must pass the API endpoint's authentication and target resolution.

Trust Boundaries and Controls

  • observed — The procedure allowlist rejects unlisted sandbox calls, and secret listing retains cloud-access and environment-visibility checks. These controls limit the new permission to authorized metadata reads, though environment visibility is not bound to the originating workspace ID.

Resilience and Maintainability Implications

  • observed — The plugin endpoint checks rate limits before resolving authentication and a plugin target. The CLI closes its MCP client after each call, but that cleanup does not restrict subsequent invocations or establish tool-level authority.

Hardening Proposals

  • proposed — Gate workspace command access by an explicit workspace-appropriate command set rather than granting the entire internal audience; verify plugin-endpoint identity and tool limits with a deployed workspace before relying on CLI visibility as a control.
  • proposed — If “its environment” is the intended confidentiality boundary, bind sandbox secret-metadata requests to the workspace's environment as well as the creator's organization authorization.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 6 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is a single, concise sentence that clearly describes the primary changes: cloud workspaces can read environment variable names and use deploy CLI credentials.
Description check ✅ Passed The description explains the motivation, implementation changes, verification steps, deployment limitation, and post-merge migration. It provides sufficient information for review.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@expo

expo Bot commented Sep 26, 2026

Copy link
Copy Markdown

No installed development build can load this pull request as an update: its native fingerprint is 63273df0c28c and no development build has it. Add the mobile-build label to build one.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit 34a3f0e into main Sep 27, 2026
22 checks passed
Kitenite added a commit that referenced this pull request Oct 1, 2026
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30

Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)".
Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23
were covered by #7771.

Changes
- Pages: no auto-open on publish (#7790); page links and URL links split
  into their own settings (#7916, #7962, #7946); Listening agents menu with
  per-row stop and Add listening agent (#7724, #7820, #7919); globe on the
  Share button (#7766); Report on public pages (#7886); agents offer a page
  (#7759). Files: pages.mdx, cli/cli-reference.mdx.
- Settings moves: Links replaced by Browser and Files & Editor (#7916,
  #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx.
- Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916),
  open and save files outside the workspace (#7897, #7982), Copy as Markdown
  (#7591), per-pane error screen (#7983). File: editor.mdx.
- Terminal copy follows Ghostty's whitespace rules (#7868).
  File: terminal-integration.mdx.
- Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired
  GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx,
  cli/cli-reference.mdx.
- Host: superset start --daemon --auto-update and update-lock permission
  errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx.
- Removed the mcp CLI section and the Connected Service Plugins section:
  #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and
  apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx,
  cli/cli-reference.mdx.
- Slack page unfurls and details panel (#7817, #7821, #7914, #7957).
  File: use-with-slack.mdx.
- Workspaces: instant creation with background naming (#7518); recoverable
  project deletion (#7896). File: workspaces.mdx.
- Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B
  collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx.
- Ship controls and open-in button moved to the right sidebar strip (#7958).
  Files: diff-viewer.mdx, use-with-ide.mdx.

Deliberately skipped
- Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule):
  #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863
  #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981
  #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR).
- Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955.
- Already documented in their own PRs: #7917, #7921.
- Removed feature never documented: #7796 Google Calendar triggers.
- Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872.
- Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792,
  #7798, #7761, #7948, #7949, #7951, #7827.
- Reverted security trio: #7828 #7829 #7830 (reverted by #7834).
- Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756
  #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860
  #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome.
- Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810
  #7814 #7816 #7889 #7968.
- Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774
  #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895
  #7909 #7933 #7934 #7942 #7944 #7965 #7966.

Validation: bun run --cwd apps/docs typecheck, bun run lint:fix,
bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings),
git diff --check.

* chore: log weekly docs update follow-ups

* docs: tighten review findings in the weekly update

Only the page creator can stop or add listening agents. On focus change also
saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do
not unfurl. Model picker coverage matches agent-models.ts.

This branch was previously deployed

1 inactive deployment
preview — 404ac536 Deployed Sep 26, 2026 by saddlepaddle via Deploy Admin #10429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant